Add method to save Fiji script parameters, and add example to opening an image #111
Conversation
Calls on scijava.script.ScriptModule through Python globals to access only the user-given parameters and not other variables at run-time.
The method now ignores password in a clean way, and skips some other non-essential runtime keys.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
=====================================
- Coverage 25% 25% -0%
=====================================
Files 25 25
Lines 1688 1710 +22
=====================================
+ Hits 421 422 +1
- Misses 1267 1288 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohangirishrao
changed the title
src/imcflibs/imagej/misc.py
Outdated
| # Skip if parameter is declared with style="password" | ||
| style = item.getWidgetStyle() | ||
| if style is not None and style.lower() == "password": | ||
| continue |
There was a problem hiding this comment.
You could use WidgetStyle.isStyle(ModuleItem<?> item, String target) here:
| # Skip if parameter is declared with style="password" | |
| style = item.getWidgetStyle() | |
| if style is not None and style.lower() == "password": | |
| continue | |
| # Skip if parameter is declared with style="password" | |
| if WidgetStyle.isStyle(item, TextWidget.PASSWORD_STYLE): | |
| continue |
Note also the use of public constants instead of hard-coded strings here 😉
There was a problem hiding this comment.
For future PR's, please try to not have completely unrelated stuff in one PR as this is more difficult to review (sure, not in the case of a docstring change, but still) and will potentially block stuff from being merged.
ehrenfeu
added
enhancement
|
Add to changelog #126 |
|
From the GitHub Actions checks: Looks like you need to update |
3 participants
Safe way of parsing Fiji script params by ignoring the passwords field automatically.